Enable automatic URL linking #19110
Enable automatic URL linking #19110
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
web/pdf_page_view.js
Outdated
| } | ||
|
|
||
| #processLinks() { | ||
| return this.pdfPage.getTextContent().then(content => { |
There was a problem hiding this comment.
We absolutely cannot fetch the textContent twice for each rendered page, since that'll be really inefficient in general.
Besides, it isn't necessary since the textContent is already available once the textLayer has rendered; see
pdf.js/web/text_layer_builder.js
Line 99 in 079eb24
pdf.js/web/text_highlighter.js
Lines 47 to 59 in 079eb24
web/pdf_page_view.js
Outdated
| #processLinks() { | ||
| return this.pdfPage.getTextContent().then(content => { | ||
| const [text, diffs] = normalizedTextContent(content); | ||
| const urlRegex = /\b(?:https?:\/\/|mailto:|www.)(?:[[\S--\[]--\p{P}]|\/|[\p{P}--\[]+[[\S--\[]--\p{P}])+/gmv; |
There was a problem hiding this comment.
Also, the regular expression should probably be created just once (and then cached) to avoid re-creating it for every page.
There was a problem hiding this comment.
This might no longer be relevant since it's now a static field on the class.
web/pdf_page_view.js
Outdated
| annotationType: 2, | ||
| annotationFlags: 4, |
There was a problem hiding this comment.
These should use actual constants, rather than hard-coded numbers.
There was a problem hiding this comment.
Removed annotationFlags and the only remaining hardcoded number now is annotationType. Ideally I should still not be assigning any of these manually and using a constructor.
ryzokuken
force-pushed
the
autolink-demo
branch
2 times, most recently
from
a7d0024 to
f3737b5
Compare
ryzokuken
force-pushed
the
autolink-demo
branch
2 times, most recently
from
cad781f to
93e5417
Compare
I was a bit unsure if I understood exactly what you were suggesting but how does this commit look? It "fetches" the textContents from the previous render of the textLayer and makes the processing step sync. |
|
@Snuffleupagus nvm my last comment, I figured it out after looking at |
Automatically detect links in the text content of a file and automatically generate link annotations at the appropriate locations to achieve automatic link detection and hyperlinking.
ryzokuken
force-pushed
the
autolink-demo
branch
from
517c74e to
7849bc0
Compare
| if ( | ||
| annotation.subtype === "Link" && | ||
| annotation.url === link.url && | ||
| Util.intersect(annotation.rect, link.rect) !== null |
There was a problem hiding this comment.
In order to avoid some corner case bug, maybe a better way to do would be to compute the ratio area(intersection) / area(annotation.rect) and if it's greater than a threshold then consider that links are very likely the same.
Automatically detect links in the text content of a file and automatically generate link annotations at the appropriate locations to achieve automatic link detection and hyperlinking.
References:
Please note that this is a WIP PR for soliciting your feedback while I work on polishing things and hopefully optimizing further.